Hacker Newsnew | past | comments | ask | show | jobs | submit | more DanOpcode's commentslogin

Yeah, I think I will do that strategy as well. I will probably put Graphene on my next phone, and if any apps don't work I will keep them on another phone.


After all years of advancement in computing, and in the year 2025 it's not possible to show a 5000 lines diff anymore.


I just mean that if you are reviewing over 5k lines of code, it suggests your PR is too big and should have been broken up into smaller changes.


It's not always code. I sometimes review things like translations that are often done in bulk (thousands of strings in a single batch). There's not much structure to it, it's not like reviewing some weird multi threaded super complicated algorithm, you just need to skim it quickly and make sure that the structure is not broken, and there are no screaming text blocks or unnecessary profanities.

Anyway, it did work properly, now it doesn't. The response shouldn't be "you're holding it wrong".


What about when you're renaming a widely used type in a large codebase or any of the many other things that it makes no sense to attempt to break up into small changes? I completely understand a preference for well-structured smaller changes, but the "large change = doing it wrong" zealotry is misguided.


I'm not always reviewing code. Sometimes I'm checking a diff between two versions of the code, which might contain multiple commits.


If someone is adding a 5k-line file, I would usually rather review it as a single chunk. And yes, sometimes a 5k-line file is entirely justified.


Linux Desktop is something else. When Adobe considers if it's worth to port Photoshop to run on the Linux Desktop they don't include the market share of Android devices in that calculation. It's two completely different markets: desktop Linux apps and Android apps.


Is it possible to toggle from miles to km?


When googling, it seems to be the opposite. That morning erection is a sign of a healthy testosterone level.


It must depend on something else. Firefox & Linux have always worked fine for me, I cannot remember when I last got restricted by a Cloudflare captcha.


Thanks, the original submission had a weird popup that I couldn't close.


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: